Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making Tutorial notebook easier to run on colab directly #239

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

jalammar
Copy link
Contributor

To make the Tutorial run on Google Colab, I had to add the two commands to install dependencies:

!sudo apt-get install fluidsynth
!pip install pretty_midi mir_eval pyfluidsynth

In case it could make it easier for folks to run the Tutorial notebook, I've added them to the top (commented), and linked to the colab in the README. PR just in case it can make it easier for new users to quickly run for the first time.

[Images in the diff should be unchanged, not sure why/how the editor changed them]

Copy link
Owner

@craffel craffel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jay! Some small changes requested.

README.md Outdated Show resolved Hide resolved
Tutorial.ipynb Outdated Show resolved Hide resolved
@craffel
Copy link
Owner

craffel commented Nov 13, 2023

Thanks Jay!

@craffel craffel merged commit 07f4174 into craffel:main Nov 13, 2023
@jalammar
Copy link
Contributor Author

Thank you! I was delighted to find the package and how easy it looks. I had always wanted some programmatic way to experiment with sounding out chords and chord progressions, and some freedom of moving MIDI around. Appreciate the effort you and all the contributors put into this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants