Loading text events and lyrics for all tracks #192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the changes requested on my previous PR. I added the
self.text_events
attribute and changed text and lyrics loading to multi-track, since for many midi files, text or lyrics events appear on tracks other than 0.Previously, I suggested classifying these events as text or lyrics depending on timing (if happening at time 0 classify as a text event, otherwise as lyrics), because it is common for annotators not to distinguish between them, but I believe it is better to leave this decision to the user.