Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scala Native and Scala 3 #342

Merged
merged 24 commits into from
May 17, 2022
Merged

Scala Native and Scala 3 #342

merged 24 commits into from
May 17, 2022

Conversation

sideeffffect
Copy link
Contributor

@sideeffffect sideeffffect commented Jan 25, 2022 •
edited
Loading

closes #340
closes #338

blocked on cquiroz/sbt-locales#190
Blocked on a new version release with this changeset scalameta/munit#477

@lolgab
Copy link
Contributor

lolgab commented May 4, 2022

sbt-locales blocked seems to be merged and released.
Can this move forward @sideeffffect ?

@cquiroz
Copy link
Owner

cquiroz commented May 4, 2022

I think this is still waiting for a munit release?

@sideeffffect sideeffffect changed the title Scala Native and Scala 3 [WIP] Scala Native and Scala 3 May 5, 2022
@sideeffffect
Copy link
Contributor Author 

[error] Found 1 missing definitions while linking
[error] Not found Top(java.lang.constant.Constable)
[error] 	at /home/runner/work/scala-java-locales/scala-java-locales/core/shared/src/main/scala/java/text/DecimalFormat.scala:390

any idea what to do @lolgab ? 🤔

@lolgab
Copy link
Contributor

lolgab commented May 5, 2022

@sideeffffect Check the workaround that was used here: scala-native/scala-native#1941

@sideeffffect
Copy link
Contributor Author

@lolgab I have no idea where I should put more explicit type annotations... generatePattern is a big function 😞

@lolgab
Copy link
Contributor

lolgab commented May 5, 2022 •
edited
Loading

@sideeffffect I would start by annotating all the values to see if it makes a difference.

@sideeffffect sideeffffect mentioned this pull request May 9, 2022
Merged
@sideeffffect sideeffffect mentioned this pull request May 15, 2022
Closed
@lolgab
Copy link
Contributor

lolgab commented May 16, 2022

I guess you can remove the [WIP] now :-)

@sideeffffect
Copy link
Contributor Author

Actually no, this PR still depends on munit 1.0.0-M3+39-d7ab5753-SNAPSHOT
Let's see when they will release a regular version (still probably Milestone, but that should be OK for us here)
https://discord.com/channels/632642981228314653/671278431102697472/975183987158958121

@sideeffffect sideeffffect changed the title [WIP] Scala Native and Scala 3 Scala Native and Scala 3 May 17, 2022
@sideeffffect
Copy link
Contributor Author

This is ready to be merged @cquiroz 🎉

@cquiroz
Copy link
Owner

cquiroz commented May 17, 2022

Do you need sbt-locales?
https://github.com/cquiroz/sbt-locales/releases/tag/v3.2.0

Ondřej Pelech added 2 commits May 17, 2022 18:06
@sideeffffect
Copy link
Contributor Author

We can do without sbt-locales 3.2.0 until you fix the PGP key for it's publishing.
This is good to be merged as it is.

cquiroz
cquiroz reviewed May 17, 2022
View reviewed changes
core/native/src/main/scala-3/java/text/Normalizer.scala
}

@link("utf8proc")
@extern
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a scala-native specific feature?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea. I just copied and adjusted whatever was in Scala 2 variant of Scala Native part of the codebase 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original code was merged as part of #356

cquiroz
cquiroz approved these changes May 17, 2022
View reviewed changes
Copy link
Owner

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot

@cquiroz cquiroz merged commit 9c85c52 into cquiroz:main May 17, 2022
@sideeffffect sideeffffect deleted the scala-native-scala-3 branch May 17, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cquiroz cquiroz cquiroz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sideeffffect @lolgab @cquiroz