Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Scala Native quirks #212

Merged
merged 6 commits into from
May 17, 2022
Merged

Cleanup Scala Native quirks #212

merged 6 commits into from
May 17, 2022

Conversation

sideeffffect
Copy link
Contributor

@sideeffffect sideeffffect commented Apr 17, 2022 •
edited
Loading

Cleans up after #190

Blocked on: portable-scala/portable-scala-reflect#42
Blocked on a new version release with this changeset scalameta/munit#477

@cquiroz
Copy link
Owner

cquiroz commented Apr 18, 2022

Nice, it has a WIP title but is it ready for review?

@sideeffffect
Copy link
Contributor Author

The changes are not big, and the further changes won't be big either, but you can still wait with reviewing this only after the blocker PR is resolved 😉

@sideeffffect sideeffffect changed the title [WIP] Cleanup Scala Native quirks Cleanup Scala Native quirks May 17, 2022
@sideeffffect
Copy link
Contributor Author

sideeffffect commented May 17, 2022 •
edited
Loading

This is ready to be merged @cquiroz 🎉
Please make a release after this is merged 🙏

cquiroz
cquiroz reviewed May 17, 2022
View reviewed changes
build.sbt
}
crossScalaVersions := Seq("2.11.12", scalaVersion212, "2.13.8", "3.1.2"),
libraryDependencies ++= List(
("org.portable-scala" %%% "portable-scala-reflect" % "1.1.2").cross(CrossVersion.for3Use2_13),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm always amzed this even works

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well... now it does 😃

cquiroz
cquiroz approved these changes May 17, 2022
View reviewed changes
Copy link
Owner

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for this

@cquiroz cquiroz merged commit c6c56d4 into cquiroz:master May 17, 2022
@sideeffffect sideeffffect deleted the cleanup-scala-native branch May 17, 2022 15:41
@sideeffffect
Copy link
Contributor Author

Do you think you can make a new release now?

@sideeffffect
Copy link
Contributor Author

@cquiroz the release didn't go though
https://github.com/cquiroz/sbt-locales/runs/6474266584?check_suite_focus=true#step%3A5%3A82=

I think I have the very same issue like this. What's going wrong is that you have outdated key (2 years by default).
You need to create a new PGP key as described here https://github.com/sbt/sbt-ci-release#gpg=

@sideeffffect
Copy link
Contributor Author

Consider also creating a key without expiration via gpg2 --full-gen-key, so that you won't have to deal with this shenanigans ever again 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cquiroz cquiroz cquiroz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sideeffffect @cquiroz