Improved parsing of templates #167
Conversation
sdkrystian
force-pushed
the
templates
branch
2 times, most recently
from
1b7f620 to
56e0d97
Compare
| NonType, | ||
| // template template parameter, e.g. "template<typename> typename T" | ||
| Template, | ||
| }; |
There was a problem hiding this comment.
Concepts are Type ?
There was a problem hiding this comment.
We don't handle concepts at all currently. Once I add partial/explicit specialization support, I'll add support for concepts & requirement clauses
There was a problem hiding this comment.
concepts are a whole other ball of yarn
| { | ||
| // default type for the type template parameter | ||
| std::optional<TypeInfo> Default; | ||
| }; |
There was a problem hiding this comment.
If there's a SymbolID in there, you could lose the optional.
sdkrystian
force-pushed
the
templates
branch
3 times, most recently
from
55272ca to
826aa52
Compare
sdkrystian
force-pushed
the
templates
branch
4 times, most recently
from
34e59ae to
fb82a73
Compare
sdkrystian
force-pushed
the
templates
branch
7 times, most recently
from
f2d90fe to
65bddb6
Compare
sdkrystian
changed the title
| enum class TemplateParamKind : int | ||
| { | ||
| // KRYSTIAN NOTE: temporary | ||
| None, |
There was a problem hiding this comment.
wtf is "None?" if this is a real thing you need to write
None = 0, // for bitstream
but if None is going away you need to sort it, I dont like having enums that arent use. For example my Access doesn't have None (but clang::AccessSpecifier does, which is irritating).
There was a problem hiding this comment.
None indicates a TParam without any extended info (e.g. TypeTParam).
| ND->isTemplateParameterPack()); | ||
|
|
||
| if(const auto* TP = dyn_cast< | ||
| TemplateTypeParmDecl>(ND)) |
There was a problem hiding this comment.
This is begging for if constexpr LOL. Not now though. Later.
sdkrystian
force-pushed
the
templates
branch
9 times, most recently
from
3853358 to
1ab2c99
Compare
No description provided.