Fix function parameter types #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests coming shortly... |
sdkrystian
force-pushed
the
func-type
branch
2 times, most recently
from
59ee8be to
d3162bc
Compare
vinniefalco
reviewed
May 4, 2023
| // function parameters as a group from the | ||
| // FunctionDecl instead of visiting ParmVarDecl. | ||
| Assert(shouldTraversePostOrder() && | ||
| "expected post-order traversal"); |
There was a problem hiding this comment.
oh man I hate this "text" in the assert
There was a problem hiding this comment.
How about "modifying a ParamVarDecl here requires post-order traversal"?
There was a problem hiding this comment.
I dont want any text at all, it is gratuituous because the assert will probably never go off so we are paying for a string for nothing. I edited the code already to remove the text and just leave a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #142