fix: CI warnings

cppalliance · Jun 23, 2023 · 5c7120b · 5c7120b
1 parent 181ac6b
commit 5c7120b
Show file tree

Hide file tree

Showing 6 changed files with 23 additions and 12 deletions.
diff --git a/include/mrdox/Metadata/Source.hpp b/include/mrdox/Metadata/Source.hpp
@@ -50,10 +50,18 @@ struct MRDOX_DECL
     }
 };
 
-/** Like std::optional<SymbolID>
+struct LocationEmptyPredicate
+{
+    constexpr bool operator()(
+        Location const& loc) const noexcept
+    {
+        return loc.Filename.empty();
+    }
+};
+
+/** Like std::optional<Location>
 */
-using OptionalLocation = Optional<Location,
-    decltype([](const Location& loc) { return loc.Filename.empty(); })>;
+using OptionalLocation = Optional<Location, LocationEmptyPredicate>;
 
 /** Stores source information for a declaration.
 */

diff --git a/source/AST/ASTVisitor.cpp b/source/AST/ASTVisitor.cpp
@@ -153,7 +153,6 @@ ASTVisitor::
 getSymbolIDForType(
     QualType T)
 {
-    SymbolID id = SymbolID::zero;
     QualType inner = T;
     while(true)
     {

diff --git a/source/AST/AnyBlock.hpp b/source/AST/AnyBlock.hpp
@@ -418,8 +418,8 @@ class BaseBlock
     BaseBlock(
         BaseInfo& I,
         BitcodeReader& br) noexcept
-        : I_(I)
-        , br_(br)
+        : br_(br)
+        , I_(I)
     {
     }
 

diff --git a/source/Support/Dom.cpp b/source/Support/Dom.cpp
@@ -107,6 +107,7 @@ Value(
     case Kind::Integer:
     case Kind::Boolean:
         number_ = other.number_;
+        break;
     case Kind::Null:
         break;
     default:
@@ -134,6 +135,7 @@ Value(
     case Kind::Integer:
     case Kind::Boolean:
         number_ = other.number_;
+        break;
     case Kind::Null:
         break;
     default:

diff --git a/source/Support/JavaScript.cpp b/source/Support/JavaScript.cpp
@@ -481,7 +481,8 @@ arr_get_impl(
     duk_context* ctx, duk_idx_t idx)
 {
     duk_require_object(ctx, idx);
-    auto found = duk_get_prop_string(ctx, idx, "ptr");
+    [[maybe_unused]] auto found =
+        duk_get_prop_string(ctx, idx, "ptr");
     MRDOX_ASSERT(found == 1);
     auto impl = reinterpret_cast<dom::Array*>(
         duk_get_pointer(ctx, -1));
@@ -506,7 +507,7 @@ arr_get_prop(duk_context* ctx)
 
     duk_push_this(ctx);
     auto arr = arr_get_impl(ctx, -1);
- 
+
     auto value = arr->get(index);
     switch(value.kind())
     {
@@ -638,7 +639,8 @@ obj_get_impl(
     duk_context* ctx, duk_idx_t idx)
 {
     duk_require_object(ctx, idx);
-    auto found = duk_get_prop_string(ctx, idx, "ptr");
+    [[maybe_unused]] auto found =
+        duk_get_prop_string(ctx, idx, "ptr");
     MRDOX_ASSERT(found == 1);
     auto impl = reinterpret_cast<dom::Object*>(
         duk_get_pointer(ctx, -1));
@@ -666,7 +668,7 @@ obj_get_prop(duk_context* ctx)
 
     duk_push_this(ctx);
     auto obj = obj_get_impl(ctx, -1);
- 
+
     auto value = obj->get(key);
     switch(value.kind())
     {

diff --git a/source/Tool/ConfigImpl.cpp b/source/Tool/ConfigImpl.cpp
@@ -189,7 +189,7 @@ createConfigFromYAML(
             workingDir, addonsDir, configYaml, extraYaml);
         return config;
     }
-    catch(Error err)
+    catch(Error const& err)
     {
         return err;
     }
@@ -224,7 +224,7 @@ loadConfigFile(
             workingDir, addonsDir, *text, extraYaml);
         return config;
     }
-    catch(Error err)
+    catch(Error const& err)
     {
         return err;
     }