handlebars generator descriptions in derived classes

#refactor
cppalliance · Jan 15, 2025 · 4031c9f · 4031c9f
1 parent df7ed7d
commit 4031c9f
Show file tree

Hide file tree

Showing 5 changed files with 35 additions and 40 deletions.
diff --git a/src/lib/Gen/adoc/AdocGenerator.cpp b/src/lib/Gen/adoc/AdocGenerator.cpp
@@ -17,11 +17,6 @@
 namespace clang::mrdocs {
 namespace adoc {
 
-AdocGenerator::
-AdocGenerator()
-    : hbs::HandlebarsGenerator("Asciidoc", "adoc")
-{}
-
 std::string
 AdocGenerator::
 toString(hbs::HandlebarsCorpus const& c, doc::Node const& I) const

diff --git a/src/lib/Gen/adoc/AdocGenerator.hpp b/src/lib/Gen/adoc/AdocGenerator.hpp
@@ -25,7 +25,24 @@ class AdocGenerator
     : public hbs::HandlebarsGenerator
 {
 public:
-    AdocGenerator();
+    std::string_view
+    id() const noexcept override
+    {
+        return "adoc";
+    }
+
+    std::string_view
+    fileExtension() const noexcept override
+    {
+        return "adoc";
+    }
+
+
+    std::string_view
+    displayName() const noexcept override
+    {
+        return "Asciidoc";
+    }
 
     std::string
     toString(

diff --git a/src/lib/Gen/hbs/HandlebarsGenerator.hpp b/src/lib/Gen/hbs/HandlebarsGenerator.hpp
@@ -28,35 +28,7 @@ namespace hbs {
 class HandlebarsGenerator
     : public Generator
 {
-    std::string displayName_;
-    std::string fileExtension_;
-
 public:
-    HandlebarsGenerator(
-        std::string_view displayName,
-        std::string_view fileExtension)
-        : displayName_(displayName)
-        , fileExtension_(fileExtension)
-    {}
-
-    std::string_view
-    id() const noexcept override
-    {
-        return fileExtension_;
-    }
-
-    std::string_view
-    displayName() const noexcept override
-    {
-        return displayName_;
-    }
-
-    std::string_view
-    fileExtension() const noexcept override
-    {
-        return fileExtension_;
-    }
-
     Expected<void>
     build(
         std::string_view outputPath,

diff --git a/src/lib/Gen/html/HTMLGenerator.cpp b/src/lib/Gen/html/HTMLGenerator.cpp
@@ -17,11 +17,6 @@ namespace clang {
 namespace mrdocs {
 namespace html {
 
-HTMLGenerator::
-HTMLGenerator()
-    : hbs::HandlebarsGenerator("HTML", "html")
-{}
-
 std::string
 HTMLGenerator::
 toString(hbs::HandlebarsCorpus const& c, doc::Node const& I) const

diff --git a/src/lib/Gen/html/HTMLGenerator.hpp b/src/lib/Gen/html/HTMLGenerator.hpp
@@ -25,7 +25,23 @@ class HTMLGenerator
     : public hbs::HandlebarsGenerator
 {
 public:
-    HTMLGenerator();
+    std::string_view
+    id() const noexcept override
+    {
+        return "html";
+    }
+
+    std::string_view
+    fileExtension() const noexcept override
+    {
+        return "html";
+    }
+
+    std::string_view
+    displayName() const noexcept override
+    {
+        return "HTML";
+    }
 
     std::string
     toString(