Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stmt,dcl] Rename labels #7485

Merged
merged 1 commit into from
Feb 10, 2025
Merged

[stmt,dcl] Rename labels #7485

merged 1 commit into from
Feb 10, 2025

Conversation

jensmaurer
Copy link
Member

No description provided.

@jensmaurer jensmaurer added this to the post-2024-11 milestone Dec 12, 2024
@AlisdairM
Copy link
Contributor

Is this a duplicate of #7179?

@jensmaurer
Copy link
Member Author

Almost. I'm not trying to rename the diff.* labels. For @tkoeppe to choose.

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 17, 2024

Yes, only the two labels we discussed, please.

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 17, 2024

@StephanTLavavej What's your take on this? How disruptive is this change? We do have the "Cross-references from C++-Prev" chapter at the end; does that help?

@StephanTLavavej
Copy link
Contributor

This isn't terribly disruptive, but I would really like for the cross-references to be permanently accumulating, instead of emptied out between Standards. The scenario here is "I'm looking at compiler/library sources that were written ten years ago and are mentioning [garfield.lasagna], and I need to find out that it's now [orange.cat.favorite.food]". This is rarely needed but when it is, it's really annoying to dig up the info.

If the purges could be retroactively undone (by gathering up each previous Standard's sections and restoring them all), that would be super awesome.

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 17, 2024

Yes, I see your point. @jensmaurer, do you think such an eternal history would be manageable?

@jensmaurer
Copy link
Member Author

Well, we already have Annex C with eternal history, so I don't see why not.

Do we want one single list (which doesn't say what happened in each revision of the standard) or per-standard-version lists as in Annex C? Maybe one single list is most useful.

@StephanTLavavej
Copy link
Contributor

A single list would be fine as far as I'm concerned - I don't care when a rename happened, I just need to find the wording.

(And as I mentioned on the reflector, it's okay to omit the rare rename where an abbreviation was embarrassing)

@jensmaurer jensmaurer modified the milestones: post-2024-11, post-2025-02 Dec 20, 2024
@AlisdairM
Copy link
Contributor

Jens has submitted #7561 that should address the need for a long-lived cross-reference of stable label evolution.

@tkoeppe
Copy link
Contributor

tkoeppe commented Feb 9, 2025

@jensmaurer Could you please rebase (and also insert a space after the comma in the label list in the commit message)?

@jensmaurer
Copy link
Member Author

@tkoeppe , done

@tkoeppe tkoeppe merged commit 9282117 into cplusplus:main Feb 10, 2025
2 checks passed
@jensmaurer jensmaurer deleted the c93 branch February 10, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants