[lex.separate] Redistribute second comment #7351
Conversation
| Translation units can be separately translated and then later linked to | ||
| produce an executable program\iref{basic.link}. |
There was a problem hiding this comment.
| Translation units can be separately translated and then later linked to | |
| produce an executable program\iref{basic.link}. | |
| Translation units can be separately translated and then linked together to | |
| produce a program\iref{basic.link}. |
This change would bring the note more in line with the choice of words in https://eel.is/c++draft/basic.link#1
I also find "and then later" to be a bit redundant; just "and then" or "and later" would suffice.
There was a problem hiding this comment.
For now I was deliberately restricting myself to moving approved words around.
I have no objections to further refining the existing text, but would rather do that as a follow-up once the text is in its new place.
There was a problem hiding this comment.
For the record, my own rewording would be more like:
"Source files can be separately translated to produce translation units and instantiation units that are later linked to create an executable program."
There was a problem hiding this comment.
side note: Of course, "instantiation units" no longer exist, really, given that we (must) have interleaved instantiation and constant evaluation.
There was a problem hiding this comment.
Are we still OK with this move then?
There was a problem hiding this comment.
Or should we wait for Reflection to land first?
There was a problem hiding this comment.
I think this would have made a good addition for N5001, so that the reflection folks could have had this slightly cleaner base to work from. As it missed P5001, I suggest we refer the authors of P2996 to look at this and pick up anything they find useful.
|
"Redistribure" typo in commit message and PR title. |
AlisdairM
changed the title
The second comment in [lex.separate] is both too specific, and not specific enough. Move the last sentence about use of separately translated TUs to the end of the first note, where it seems most appropriate. Move the rest of the note to the end of translation phase 8, where we are in a position to talk about preserving the separately translated TUs *and instantiation units* for linking in phase 9.
AlisdairM
force-pushed
the
redistribute_lex_comment
branch
from
60fc14b to
9bffba9
Compare
|
Corrected commit message, rebased, and force-pushed. |
|
This text is subject to active work (P2996), please revisit after motions. |
|
I think I want reflection to land first. It's probably not changing this exact sentence, but words in the vicinity. |
The second comment in [lex.separate] is both too specific, and not specific enough. Move the last sentence about use of separately translated TUs to the end of the first note, where it seems most appropriate. Move the rest of the note to the end of translation phase 8, where we are in a position to talk about preserving the separately translated TUs and instantiation units for linking in phase 9.