Skip to content

Conversation

@hewillk
Copy link
Contributor

@hewillk hewillk commented May 10, 2024

This is consistent with [range.as.rvalue.overview]. Is this editorial?

@jensmaurer
Copy link
Member

@jwakely , any opinion here?

@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 17, 2025

@hewillk Please rebase.

@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 17, 2025

Also @CaseyCarter?

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 5, 2025

@jwakely Ping?

@CaseyCarter
Copy link
Contributor

A common_range is not necessarily an input_range, so I don't think the suggested change is "consistent with [range.as.rvalue.overview]". I don't immediately see if common_range<decltype((E))> implies that views::all(E) is well-formed, so I'd say this is not editorial.

@hewillk
Copy link
Contributor Author

hewillk commented Nov 7, 2025

A common_range is not necessarily an input_range, so I don't think the suggested change is "consistent with [range.as.rvalue.overview]".

That's true for now, but LWG 4083 didn't exist when I submitted this PR.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 7, 2025

Thanks, @CaseyCarter! Let's close this then, and @hewillk please submit an LWG issue if you think this needs to be changed.

@tkoeppe tkoeppe closed this Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants