-
Notifications
You must be signed in to change notification settings - Fork 803
[futures.async] Avoid note within a sentence. #4232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| \begin{note} | ||
| \tcode{f} might not be called at all, | ||
| so its completion might never happen. | ||
| \end{note} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about this other note -- would it also work better outside the list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe. I'm trying to limit the size of the changes this late in the process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could further limit the size of the changes by turning these bullets into proper sentences. (There's already a period before the first note.) Eg:
Synchronization: The following apply regardless of the provided
policyargument:
- The invocation of
asyncsynchronizes with the invocation off.
[Note:...]- The completion of the function
fis sequenced before the shared state is made ready.
[Note:...]
For master we could be a bit more aggressive:
Synchronization: The invocation of
asyncsynchronizes with the invocation off. The completion of the functionfis sequenced before the shared state is made ready.
[Note: These apply regardless of the providedpolicyargument, and even if the correspondingfutureobject is moved to another thread. However,fmight not be called at all, so its completion might never happen.]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like both parts of this.
|
This is now the minimal fix against C++20. Please check. |
|
The larger fix for C++23 is in #4244. |
Partially addresses #4228
After this is merged, check page break in [futures.task.members].