Fix error when trying to plot labels in a gap in the data #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottshambaugh
changed the title
Owner
|
Many thanks, that's great to have! I agree the best solution would be to avoid the nans altogether, but I cannot think of a one-fits-all solution. |
Owner
|
Geez, I made a mistake and merged before fixing the CI... |
This was referenced Mar 7, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the error in #209, although a better fix would avoid plotting in the data gaps altogether (by putting checks in the
ok_matrixcalculations). This is better than nothing though.Similar issue with running the image comparison test locally as in #210, so would appreciate some guidance there.