Add source information to HealthDataPoint #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added two new fields to the HealthDataPoint, SourceId and SourceName and populate when data is read. This allows datapoints to be disambigous and in some cases allows us to get more accurate data. For example the number of steps can be reported from Apple Health and Watch and without source data they are aggregated into just "steps" producing an innacurate result. On iOS source is derived from sample.sourceRevision.source (https://developer.apple.com/documentation/healthkit/hksourcerevision) with id coming from bundleIdentifier ("com.apple.health") and name from name ("Health") On Android source is derived from dataPoint.getOriginalDataSource() (https://developers.google.com/android/reference/com/google/android/gms/fitness/data/DataPoint#getOriginalDataSource())with id from getStreamIdentifier and name getAppPackageName
|
Thanks for this PR - have been incorporated and published as version 3.0.6. |
hibitness-quan-nguyen2
pushed a commit
to hibitness/flutter-plugins
that referenced
this pull request
Dec 18, 2023
Add source information to HealthDataPoint
|
Does it give me total steps in given day or list of all the sessions of steps? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two new fields to the HealthDataPoint, SourceId and SourceName and populate when data is read. This allows datapoints to be disambigous and in some cases allows us to get more accurate data. For example the number of steps can be reported from Apple Health and Watch and without source data they are aggregated into just "steps" producing an innacurate result.
On iOS source is derived from sample.sourceRevision.source (https://developer.apple.com/documentation/healthkit/hksourcerevision) with id coming from bundleIdentifier ("com.apple.health") and name from name ("Health")
On Android source is derived from dataPoint.getOriginalDataSource() (https://developers.google.com/android/reference/com/google/android/gms/fitness/data/DataPoint#getOriginalDataSource())with id from getStreamIdentifier and name getAppPackageName