This repository has been archived by the owner on Jun 12, 2018. It is now read-only.
Fix color format and recurring event issue #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jsilvestre
commented
Nov 6, 2015
jsilvestre
commented
- Fix color format to always be in hexadecimal. Refs tag.color format sin't consistent #435
- Fix recurring event issue with daylight saving. Refs Wrong timezone for recurring events #433
jsilvestre
changed the title
| else if @isRecurrent() and not @has('timezone') | ||
| s = moment.tz(m, @get('timezone')).toISOString() | ||
| else if @isRecurrent() | ||
| s = H.momentToAmbiguousString(m) |
There was a problem hiding this comment.
H, m, s ... These variable names are awful and don't follow the guidelines. Can you fix this? It matters for readibility and maintenability.
aenario
pushed a commit
that referenced
this pull request
Nov 12, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.