Mark interaction as internalizable instead of dropping it #931
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimization pipeline which should improve the objective value of a settlement by applying a few gas optimizations can cause solutions that are not viable to pass the simulation by internalizing AMM interactions that are overly optimistic.
Check out this trade selling
USDC
forAMPL
.Paraswap
currently gives too optimistic prices forAMPL
. That means the settlement provided byparaswap
would likely have reverted. Because the order was sellingUSDC
(a trusted token) the optimization pipeline was allowed to internalize the erroneous AMM interaction which resulted in a working settlement with an unbeatable price (because we pay with our buffers).I saw 2 ways to tackle this issue:
I decided to go with
2
because together with #843 it should prevent the same problems while offering better debuggability than1
.Test Plan
?