Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to cowprotocol/ethcontract-rs#872
This PR bumps the version of
ethcontract
to one that detects additional revert RPC errors from Nethermind that were previously being missed.This should decrease alert noise as we were alerting on fetching owner token balances in the bad token detector that were reverting, but, now with the newer version of
ethcontract
, should be categorized as aREVERT
and be handled accordingly (basically, it would not find a balance for that token).Test Plan
Try out with a contract that was causing the issue (basically, it wasn't a token). Previously, trying to get a native token price for a specific address was causing an internal server error (which generates alert noise):
With the proposed change, this is no longer the case: