Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch liquidity after order check #857

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Fetch liquidity after order check #857

merged 2 commits into from
Nov 28, 2022

Conversation

vkgnosis
Copy link
Contributor

@vkgnosis vkgnosis commented Nov 28, 2022 •
edited
Loading

We exit the run loop early if there is no mature user order check. In this case we don't make use of liquidity so we can avoid some work by fetching liquidity afterwards.

Test Plan

CI, not directly tested

@vkgnosis
Fetch liquidity after order check
2ec1b49 
We exit the run loop early if there is no mature user order check. In
this case we don't make use of liquidity so we can avoid some work by
fetching liquidity afterwards.
@vkgnosis vkgnosis requested a review from a team as a code owner November 28, 2022 11:56
MartinquaXD
MartinquaXD approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@MartinquaXD MartinquaXD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: The PR description still has some of its template text.

@vkgnosis vkgnosis enabled auto-merge (squash) November 28, 2022 13:44
sunce86
sunce86 approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@sunce86 sunce86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice tweak :)

@vkgnosis vkgnosis merged commit 2abf0a3 into main Nov 28, 2022
@vkgnosis vkgnosis deleted the liqudidty-get branch November 28, 2022 13:49
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sunce86 sunce86 sunce86 approved these changes

@MartinquaXD MartinquaXD MartinquaXD approved these changes

@nlordell nlordell nlordell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vkgnosis @nlordell @MartinquaXD @sunce86