-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gelato API Module #839
Conversation
Is it useful to add this when we currently can't use Gelato because require knowing the submitting account and nonce to associate auctions with their tx hashes? |
We plan on experimenting with it on test-nets and layer 2s where solver rewards aren't needed. Until the, the For the submitter - I can add a |
Actually, this isn't needed because the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed there is no gas price in the request sent to API.
After reading the docs, saw that there is a gas price oracle we are not using, and also we don't define a cap on maximum cost we are willing to pay for a transaction.
Code LG overall. I think we can address this concerns in the follow up PR (if needed)
Follow up to #599
I previously experimented with a Gelato relay service submitter in #599. The idea is to allow a separate relay service to execute settlement transactions on behalf of solvers so that they don't have to worry about execution details.
This PR is the first in a stack of 3 for enabling Gelato submission support. I am basically just breaking down the existing #599 into smaller pieces to make them easier to review and "self-contained".
In the following PRs I will:
Test Plan
Added a manual test for executing a transaction over the Gelato relay. Requires a 1Balance account with an API key.
Check the executed transaction on Görli: https://goerli.etherscan.io/tx/0x00f1e1ebeff7df0cf7bd1b27b478085d842b7e0af99478a939b2a68ed6ba9c23.