Doc comments 1 #837
Merged
Doc comments 1 #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinquaXD
approved these changes
Nov 23, 2022
vkgnosis
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
For some of this documentation it would be even nicer (the PR is good too, I'm just thinking out loud) if we had a place on https://cow.fi/ to link to because technical users of the exchange or the api will have the same question and it would be better to have the information consolidated in one place.
fedgiac
reviewed
Nov 23, 2022
fedgiac
reviewed
Nov 23, 2022
fedgiac
approved these changes
Nov 25, 2022
nlordell
reviewed
Nov 28, 2022
| @@ -6,6 +6,9 @@ use std::{ | |||
| str::FromStr, | |||
| }; | |||
|
|
|||
| /// This allows arbitrary user data to be associated with an order. This type holds the | |||
| /// hash of the data, while the data itself is uploaded to IPFS. The hash is signed along with the | |||
There was a problem hiding this comment.
Note that this isn't enforced.
Co-authored-by: Federico Giacon <[email protected]>
Co-authored-by: Federico Giacon <[email protected]>
sistemd
force-pushed
the
doc-comments-1
branch
from
e3cbce4
to
854ce95
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some doc comments explaining things I was curious about.
Please let me know if I got anything wrong 😄