Fix Mature Orders Algorithm #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #826
By observing the logs multiple solvers submitted the same solution containing only one order, where Baseline solver solution was considered mature while others not (Baseline solver ended as the winner).
I found the case where existing algorithm is not working which is documented by the unit test
mature_by_association_in_betweenTest Plan
Unit test
mature_by_association_in_betweenpassing. Revert the fix and make sure the unit test fails in that case. ->s2solution not being considered mature while the exact sames4is considered mature.