Refactor shared components in refunder e2e test #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedgiac
force-pushed
the
refactor-refunder-e2e
branch
from
f39acb1
to
6596ea8
Compare
nlordell
reviewed
Nov 18, 2022
nlordell
approved these changes
Nov 18, 2022
MartinquaXD
reviewed
Nov 18, 2022
vkgnosis
approved these changes
Nov 18, 2022
MartinquaXD
approved these changes
Nov 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors a few shared components in preparation fort the eth flow e2e test.
Some minor logic changes are consequence of the refactor but I consider them inconsequential:
buy_amount = 1, the order is modified to include a slippage tolerance of 99.99%. This should make it clear that extra slippage must be included for the refunder to work (I stumbled on this for longer than I should have).Test Plan
CI: e2e test still works.