Remove solver_competition tx_hash column #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlordell
approved these changes
Nov 16, 2022
nlordell
reviewed
Nov 16, 2022
nlordell
reviewed
Nov 16, 2022
nlordell
reviewed
Nov 16, 2022
MartinquaXD
approved these changes
Nov 17, 2022
| @@ -435,20 +441,6 @@ impl Driver { | |||
| }; | |||
| if let Some(hash) = hash { | |||
| tracing::debug!(?hash, "settled transaction"); | |||
There was a problem hiding this comment.
suggestion: At this point we might as well drop if let Some(hash)... and just put specific log statements into each match arm.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #634 .
Now that staging and prod are running the tx_from, tx_nonce code we can remove tx_hash.
The reward payout script has been updated in cowprotocol/solver-rewards#131 .
Test Plan
CI