Indexing order cancellations #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josojo
force-pushed
the
ordercancellations
branch
from
bfcf712
to
430e085
Compare
vkgnosis
approved these changes
Nov 16, 2022
fedgiac
approved these changes
Nov 16, 2022
josojo
force-pushed
the
ordercancellations
branch
from
5c0e74d
to
29c1d62
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #708.
Finishes the indexing of the onchain order invalidations.
Unfortunately, we needed to redeploy the contracts, hence the new contract version. We needed to redeploy, as we had the order_uids marked as "indexed" in the smart contract and then the order_uid was not readable from the logs. See here for more information.
Test Plan