Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log Batched Buffered Requests #774

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Log Batched Buffered Requests #774

merged 1 commit into from
Nov 14, 2022

Conversation

nlordell
Copy link
Contributor

I noticed when debugging that we only log TRACE logs for the buffered transport if they are single calls, and not if they are batched calls. This PR fixes that.

Test Plan

CI.

@nlordell nlordell requested a review from a team as a code owner November 14, 2022 16:37
@nlordell nlordell enabled auto-merge (squash) November 14, 2022 16:37
sistemd
sistemd approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@sistemd sistemd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@nlordell nlordell merged commit 351e19a into main Nov 14, 2022
@nlordell nlordell deleted the log-batched-buffered-requests branch November 14, 2022 17:57
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sistemd sistemd sistemd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlordell @sistemd