[refunder] submitting txs #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josojo
force-pushed
the
refunderWithNewContract
branch
2 times, most recently
from
f083691
to
a1315d4
Compare
josojo
force-pushed
the
refunderWithNewContract
branch
from
a1315d4
to
b79a009
Compare
vkgnosis
reviewed
Nov 15, 2022
MartinquaXD
reviewed
Nov 15, 2022
Merged
MartinquaXD
reviewed
Nov 16, 2022
fedgiac
reviewed
Nov 16, 2022
vkgnosis
reviewed
Nov 16, 2022
Comment on lines
+154
to
+158
| // The gas price of the refund tx is the current prevailing gas price | ||
| // of the web3 gas estimation plus a buffer. | ||
| // Since we are using Eip1559 gas specification, | ||
| // we will only pay the buffer if it is used | ||
| let mut new_max_fee_per_gas = max_fee_per_gas * GAS_PRICE_BUFFER_FACTOR; |
There was a problem hiding this comment.
Why don't we do it this way in services too? I feel like we could simplify our code in the same way.
vkgnosis
approved these changes
Nov 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue: #626
This PR has the logic to make the refunder submit the actual refund tx.
The overall loop goes like this:
Test Plan
I added some unit tests. E2e test is provided in this PR: #776