Adjust Market Order Logic When Limit Orders Are Disabled #758
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the order classification logic.
Specifically, when limit orders were disabled, it was possible to create market orders with a 0-fee (as the 0-fee would cause it to skip the
get_quote_and_check_fee
fee check but disabled limit orders make the order be considered a market order).@fedgiac and I already applied a hotfix in production, this PR adds the fix to
main
aswell. This is not urgent (as limit orders are enabled in staging, so it is not possible to create 0-fee market orders ATM).
Additionally, this PR also:
Test Plan
Changed the test that checks 0-fee market orders error validation when limit orders are disabled, and added a new test to prevent regressions of the liquidity classification for out-of market orders.