Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode pre-interactions for settlement #623

Merged
merged 16 commits into from
Oct 19, 2022
Merged

Encode pre-interactions for settlement #623

merged 16 commits into from
Oct 19, 2022

Conversation

josojo
Copy link
Contributor

@josojo josojo commented Oct 11, 2022 •
edited
Loading

Encodes the pre_interactions of the orders into the settlement. It also filters for duplicated interactions and removes them.

Additionally, it lifts the interaction trait from the solver crate into the shared crate: We want to use the same trait Interaction with the same encode interface, as for pre-interactions of orders.

Test Plan

@josojo josojo marked this pull request as ready for review October 12, 2022 06:30
@josojo josojo requested a review from a team as a code owner October 12, 2022 06:30
Base automatically changed from pre_interactions2a to pre_interactions2 October 13, 2022 08:54
vkgnosis
vkgnosis reviewed Oct 18, 2022
View reviewed changes
crates/model/Cargo.toml Outdated Show resolved Hide resolved
nlordell
nlordell suggested changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@nlordell nlordell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change overall!

I don't agree with duplicating the InteractionData struct though (and the reason for the "requested changes"). Maybe just a re-export pub use model::interaction::InteractionData might be more appropriate?

Base automatically changed from pre_interactions2 to main October 19, 2022 20:14
@josojo josojo enabled auto-merge (squash) October 19, 2022 20:52
@josojo josojo merged commit 81706c6 into main Oct 19, 2022
@josojo josojo deleted the pre_interaction3a branch October 19, 2022 21:06
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkgnosis vkgnosis vkgnosis approved these changes

@nlordell nlordell nlordell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josojo @nlordell @vkgnosis