Sunce86/temporary logs for custom nodes #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlordell
approved these changes
Apr 4, 2022
Codecov Report
@@ Coverage Diff @@
## main #3 +/- ##
==========================================
+ Coverage 65.10% 65.12% +0.01%
==========================================
Files 182 182
Lines 38036 38049 +13
==========================================
+ Hits 24763 24779 +16
+ Misses 13273 13270 -3 |
MartinquaXD
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more logs so we could identify the issue with not dropping futures in case of
CustomNodesstrategy.Will revert this PR after the analysis.