[EASY] Improve config group for blockscout and ethplorer #2924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed. |
MartinquaXD
reviewed
Sep 2, 2024
| pub blockscout_api_key: Option<String>, | ||
| /// The blockscout configuration. | ||
| #[clap(flatten)] | ||
| pub blockscout: Blockscout, |
There was a problem hiding this comment.
Shouldn't the groups themselves be optional and the individual fields in the struct be required?
That way you only have the blockscout struct if everything is configured correctly and don't have to map optionals awkwardly.
There was a problem hiding this comment.
Seems like this can be achieved by making the fields not Options but setting required=false on the field macro.
m-lord-renkse
commented
Sep 2, 2024
| @@ -241,7 +241,7 @@ pub struct Arguments { | |||
| pub fn display_secret_option<T>( | |||
| f: &mut Formatter<'_>, | |||
| name: &str, | |||
| option: &Option<T>, | |||
| option: Option<&T>, | |||
There was a problem hiding this comment.
&Option<T> is an anti-pattern.
m-lord-renkse
force-pushed
the
improve-config-groups
branch
2 times, most recently
from
521f246
to
9e4f68b
Compare
m-lord-renkse
force-pushed
the
improve-config-groups
branch
from
9e4f68b
to
8c1ba7d
Compare
MartinquaXD
approved these changes
Sep 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve the groups for
ethplorerandblockscoutinspired by the CoinGecko configuration done in: #2909How to test
1.Unit test