Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol fees breakdown #2879

Merged
merged 8 commits into from
Aug 13, 2024
Merged

Protocol fees breakdown #2879

merged 8 commits into from
Aug 13, 2024

Conversation

sunce86
Copy link
Contributor

@sunce86 sunce86 commented Aug 9, 2024

Description

Implements task 2 1 from #2862:

Extend order_execution with a field that contains a list of executed protocol fees in surplus token, together with the surplus token address

autopilot::domain::Settlement now exposes breakdown of protocol fees in surplus token.

Applies the same refactoring to driver, to keep the code 1:1 (and also to use driver tests to confirm no bugs were introduced).

How to test

Existing tests.

@sunce86 sunce86 requested a review from a team as a code owner August 9, 2024 11:34
Copy link
Contributor

@fleupold fleupold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change described in the description and the actual change in the code seem quite different (likely a rebasing issue?).

@sunce86
Copy link
Contributor Author

sunce86 commented Aug 9, 2024

The change described in the description and the actual change in the code seem quite different (likely a rebasing issue?).

I updated the description. Is it ok now?

Copy link
Contributor

@squadgazzz squadgazzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@sunce86 sunce86 enabled auto-merge (squash) August 13, 2024 09:54
@sunce86 sunce86 merged commit cd40c68 into main Aug 13, 2024
10 checks passed
@sunce86 sunce86 deleted the fees-breakdown branch August 13, 2024 10:01
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants