Fix NonExistentPoolMap #2853
Merged
Fix NonExistentPoolMap #2853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have been using HashSetDelay incorrectly. The expiration time is only respected if the set is turned into a stream and awaited on (it will return
Errfor expired items).This interface is very clunky and doesn't really serve our use case.
Changes
How to test
Existing tests pass. Also, in the next PR I will add an e2e test that actually relies on the non-existent pool cache to be reset (as liquidity appears throughout the lifetime of the test)