Fix index for ethflow_orders table #2836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reminder: Please update the DB Readme. Caused by: |
fleupold
approved these changes
Jul 25, 2024
m-lord-renkse
approved these changes
Jul 25, 2024
squadgazzz
approved these changes
Jul 25, 2024
|
We have 2 identical indexes: user_valid_to and order_valid_to, right? One should be dropped. |
|
Relevant to #2831 (comment) |
Dropped |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously index was created on a wrong table: "orders" instead of "ethflow_orders":
https://github.com/cowprotocol/services/blob/main/database/sql/V031__create_ethflow_orders.sql#L11
Should speed up the OPEN_ORDERS query, although not sure how much.