Autopilot refactor 2/3: Build Observation object #2835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-lord-renkse
approved these changes
Jul 25, 2024
fleupold
approved these changes
Jul 25, 2024
fleupold
reviewed
Jul 30, 2024
| @@ -20,25 +26,41 @@ pub use {auction::Auction, solution::Solution, transaction::Transaction}; | |||
| #[derive(Debug)] | |||
| pub struct Settlement { | |||
| solution: Solution, | |||
| transaction: Transaction, | |||
There was a problem hiding this comment.
I missed this. If we are adding the transaction here, can't we get rid of the solution field? It can now be computed on the fly (as long as we also have the domain separator somehow) and we avoid storing redundant information.
| } | ||
|
|
||
| /// CIP38 score calculation | ||
| pub fn score(&self) -> Result<competition::Score, solution::error::Score> { | ||
| self.solution.score(&self.auction) | ||
| } | ||
|
|
||
| /// Returns the observation of the settlement. | ||
| pub fn observation(&self) -> Observation { |
There was a problem hiding this comment.
Is this the object that is meant to replace SettlementUpdate? I think we should simply pass the Settlement object and make all those fields getter variables on Settlement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ports building observation data which is supposed to be saved to the database.
Equivalent to: https://github.com/cowprotocol/services/blob/main/crates/autopilot/src/on_settlement_event_updater.rs#L243-L260
How to test
Added Observation object printing to
OnSettlementEventUpdater