Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deny listing balancer pools #248

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Conversation

vkgnosis
Copy link
Contributor

@vkgnosis vkgnosis commented Jun 2, 2022

Fixes #242 .

Test Plan

Used the new manual pool fetching test to see that this pool no longer gets returned

@vkgnosis vkgnosis requested a review from a team as a code owner June 2, 2022 11:12
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2022

Codecov Report

Merging #248 (8a8eda3) into main (3861021) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 8a8eda3 differs from pull request most recent head d7baa03. Consider uploading reports for the commit d7baa03 to get more accurate results

@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
- Coverage   64.35%   64.33%   -0.02%     
==========================================
  Files         191      191              
  Lines       39533    39540       +7     
==========================================
- Hits        25443    25440       -3     
- Misses      14090    14100      +10     

Copy link
Contributor

@sunce86 sunce86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@josojo josojo self-requested a review June 2, 2022 11:29
Copy link
Contributor

@josojo josojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkgnosis vkgnosis enabled auto-merge (squash) June 2, 2022 11:31
@vkgnosis vkgnosis merged commit c766b5a into main Jun 2, 2022
@vkgnosis vkgnosis deleted the balancer-pool-deny-list branch June 2, 2022 11:35
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable deny list for balancer pools
4 participants