Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #243
This PR extends the 0x API implementation to allow setting excluded sources for
/swap
and/quote
queries and adds configuration options in the driver and orderbook for setting these excluded sources.Test Plan
Added a new test to see if 0x takes different routes when buying SNX for route (i.e. it doesn't use the "bad" Balancer pool):
Notice that the results are different in both cases and that when
Balancer_V2
is excluded, the calldata no longer contains the0xba1222....
Vault address.