Change quote request construction for fee and quote #234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently added a regression to the "legacy"
api/v1/feeAndQuote
API endpoint.Under the hood, this request uses the same logic as for
api/v1/quote
which recently introduced a cap on thevalid_to
field. This broke the aforementioned fee and quote route which was internally converting the request into a quote withvalid_to
set tou32::MAX
.This PR fixes this by changing the order quote construction to use a "sane"
valid_to
value: the default validity that is used in the CowSwap UI - which should be super unlikely to ever become "invalid" and break the legacy API.Test Plan
api/v1/feeAndQuote
should start working again!