Add objective Flag And use SuplusFeesCosts for Price Estimates
#229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The parameter is called |
|
Oops 🙈 - fixed. |
twalth3r
reviewed
May 25, 2022
twalth3r
reviewed
May 25, 2022
twalth3r
reviewed
May 25, 2022
harisang
reviewed
May 25, 2022
| @@ -38,7 +38,7 @@ use shared::{ | |||
| }, | |||
| baseline_solver::BaseTokens, | |||
| current_block::current_block_stream, | |||
| http_solver::{DefaultHttpSolverApi, SolverConfig}, | |||
| http_solver::{DefaultHttpSolverApi, Objective, SolverConfig}, | |||
There was a problem hiding this comment.
Is this change needed here, or is the new parameter part of SolverConfig?
There was a problem hiding this comment.
Its a new parameter part of SOlverConfig.
Driver creates one with default objective (so nothing specified in the query URL) for solving batches and the orderbook creates on with objective set to surplusfeescosts for price estimates.
|
Sorry @twalth3r, so many brain-farts. Hopefully should be correct now. |
nlordell
changed the title
optimize Flag And use SuplusFeesCosts for Price Estimatesobjective Flag And use SuplusFeesCosts for Price Estimates
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new field to
SolverConfigto allow configuring Quasimodo for different environments. Specifically, requests to Quasimodo from the solver should use a different objective then when requesting price estimates (when solving, Quasimodo defaults to optimizing with capped surplus, which we don't want for price estimates).Test Plan
Run the orderbook locally and see the new parameter: