Randomize Winner on Objective Value Tie #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #227 +/- ##
=======================================
Coverage 64.47% 64.48%
=======================================
Files 189 189
Lines 39051 39053 +2
=======================================
+ Hits 25177 25182 +5
+ Misses 13874 13871 -3 |
MartinquaXD
approved these changes
May 24, 2022
crates/solver/src/driver.rs
Outdated
| @@ -658,6 +658,10 @@ impl Driver { | |||
| self.metrics.settlement_simulation_succeeded(solver.name()); | |||
| } | |||
|
|
|||
| // Before sorting, make sure to shuffle the settlements. This is make sure we give | |||
There was a problem hiding this comment.
This is making sure we don't give preference...
There was a problem hiding this comment.
🤣
Unfortunately rustc doesn't check my English grammar and semantics. Maybe Rust edition 2024?
sunce86
approved these changes
May 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just randomizes the rated settlements before "stable"-sorting them. This makes it so in case of a tie in the objective value, solvers are treated equally.
Test Plan
CI and Rust compiler.