Record request ID from Cloudfront #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlordell
commented
May 23, 2022
| @@ -198,10 +201,19 @@ pub fn handle_all_routes( | |||
| .allow_headers(vec!["Origin", "Content-Type", "X-Auth-Token", "X-AppId"]); | |||
There was a problem hiding this comment.
Note that we intentionally don't add it to the list of allowed CORS headers.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fulfills #215
This PR will use an externally set request ID with an info span from the
X-Request-IDheader (falling back to an internal counter if the aforementioned header is not available).The motivation behind this change is to request logs in the orderbook API for specific Cloudfront HTTP requests.
Test Plan
You can test this locally by running the orderbook and using
curl:And check that the log message include the request ID:
Whether or not
X-Request-IDis the correct header, we will see once this hits staging. That being said, some quick Googling reveals this is a fairly common header to use for identifying requests from reverse proxies.