Use gas limit for tenderly simulation #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinquaXD
reviewed
May 18, 2022
| @@ -171,6 +171,7 @@ pub async fn simulate_before_after_access_list( | |||
| from, | |||
| input: transaction.input.0, | |||
| to, | |||
| gas: Some(transaction.gas.as_u64()), | |||
There was a problem hiding this comment.
Is it also required to supply the gas price here?
I assume these are possible parameters?
There was a problem hiding this comment.
Gas price is irrelevant for both access list and gas used calculations.
There was a problem hiding this comment.
Technically, this may be important. See gnosis/gp-v2-services#883
If its not too much work, I would also include the gas price here to prevent simulation issues ☝️
There was a problem hiding this comment.
Hm, interesting. The only thing I knew about is that we had some differences in transaction simulation when the sender does not have enough funds for transaction fee.
Anyway, for our piece of mind, let's add it: #207
MartinquaXD
approved these changes
May 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access list
gas_usedcalculation uses Tenderly simulation API.However, a bug was noticed: https://logs.gnosis.io/goto/35666490-d6aa-11ec-89c6-1d03c10630c7
Value for
gas_usedwas abnormal because sometimes, when transaction reverts, the EVM spends all the remaining gas up until the provided transaction gas limit. Since we did not set gas limit when calling Tenderly API, calculatedgas_usedended up being a high number.This PR adds the gas limit for cases when Tenderly API is used for calculation of the
gas_used. For other cases, for example, when Tenderly API is used for access list calculation, gas limit is irrelevant, soNoneis provided in that case.Test Plan
Unit test
simulate_before_after_access_list_testpasses.