Track time to trade for user and liquidity orders separately #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #203 +/- ##
==========================================
+ Coverage 64.40% 64.42% +0.01%
==========================================
Files 189 189
Lines 38780 38785 +5
==========================================
+ Hits 24977 24986 +9
+ Misses 13803 13799 -4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for long open liquidity orders to not affect the time to trade for user orders their trading times need to be tracked separately.
This was left over after this PR which only tracked the matching quote for user and liquidity order separately (the name of the old PR was incorrect).
Test Plan
Existing unit test covers this metric.