Add HTTP headers for external solver requests #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #201 +/- ##
=======================================
Coverage 64.41% 64.41%
=======================================
Files 189 189
Lines 38775 38780 +5
=======================================
+ Hits 24977 24981 +4
- Misses 13798 13799 +1 |
MartinquaXD
approved these changes
May 16, 2022
sunce86
approved these changes
May 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds HTTP headers indicating that external solver
/solverequests both send and only accept JSON.This is just to be more polite to solvers as some frameworks have friction if the header is missing or not set to
application/json.Test Plan
CI.