Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log for order created uid #199

Merged
merged 2 commits into from
May 16, 2022
Merged

Add log for order created uid #199

merged 2 commits into from
May 16, 2022

Conversation

sunce86
Copy link
Contributor

@sunce86 sunce86 commented May 14, 2022

This PR adds logging of the newly created order's Uid.

Using this Uid and the log timestamp we can connect the orderbook::api::request_summary log with the order logs in the solver.

Tried to find the cleaner way to add this log directly to the orderbook, but once the response is wrapped into ApiReply it becomes cumbersome to extract the needed Uid.

@sunce86 sunce86 requested a review from a team as a code owner May 14, 2022 14:46
@codecov-commenter
Copy link

Codecov Report

Merging #199 (307ef90) into main (c346f3a) will decrease coverage by 0.26%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
- Coverage   64.71%   64.44%   -0.27%     
==========================================
  Files         190      189       -1     
  Lines       39045    38751     -294     
==========================================
- Hits        25268    24974     -294     
  Misses      13777    13777              

@sunce86 sunce86 enabled auto-merge (squash) May 16, 2022 11:30
@sunce86 sunce86 merged commit 4ac71cd into main May 16, 2022
@sunce86 sunce86 deleted the sunce86/add-log-for-order-uid branch May 16, 2022 11:33
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants