Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

making oneInch slippage configurable #196

Merged
merged 1 commit into from
May 11, 2022
Merged

making oneInch slippage configurable #196

merged 1 commit into from
May 11, 2022

Conversation

josojo
Copy link
Contributor

@josojo josojo commented May 11, 2022

Since we have quite some failures in production, we would like to increase the slippage

testplan:
none

@josojo josojo requested a review from a team as a code owner May 11, 2022 12:48
vkgnosis
vkgnosis approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@vkgnosis vkgnosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this MAX_SLIPPAGE_BPS is only used in balancer solver so should probably make this configurable eventually too.

@josojo josojo mentioned this pull request May 11, 2022
Closed
@josojo josojo merged commit c346f3a into main May 11, 2022
@josojo josojo deleted the 1inchsolverconfig branch May 11, 2022 13:33
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkgnosis vkgnosis vkgnosis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josojo @vkgnosis