Send solver competition info to api from driver #193
Conversation
vkgnosis
changed the title
| // TODO: we don't have access to this and there is no guarantee there is one such block | ||
| competition_simulation_block: 0, |
There was a problem hiding this comment.
Regarding this TODO and the one below - do you think it makes sense to return this along with the simulations that we already do?
Specifically we can add a eth_getBlockNumber(latest) to the request batch and return the computed calldata along with the simulation result that computes the gas used.
You mentioned below that some refactoring to make this happen, I'm not sure if this is what you had in mind.
There was a problem hiding this comment.
For both the todos we need a little bit of refactoring yeah. The reason here it doesn't completely work is that we split up over multiple batches if there are too many simulations. These batches could happen in different block numbers. (Really we don't even have a guarantee that a batch always happes in the same block either.)
There was a problem hiding this comment.
Really we don't even have a guarantee that a batch always happes in the same block either.
Oh yeah, that's a good point. It may be nice as an indicative value anyway even if its not accurate.
Codecov Report
@@ Coverage Diff @@
## main #193 +/- ##
==========================================
- Coverage 64.86% 64.74% -0.12%
==========================================
Files 190 190
Lines 38966 39033 +67
==========================================
- Hits 25275 25273 -2
- Misses 13691 13760 +69 |
Part of #127 .
There are some minor todos that I don't want to be blocking the main part of this PR so I want to merge this part first.
Test Plan
CI and manual verification that this works