Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce log level of noisy debug messages #192

Merged
merged 2 commits into from
May 6, 2022
Merged

Conversation

fleupold
Copy link
Contributor

@fleupold fleupold commented May 5, 2022

In order to make debugging and oncall activity easier, I find it nice if activating the filter log is not 'DEBUG' in Kibana shows me a good summary overview of what is happening in the system on each runloop. Then, if I actually want to debug a specific loop, I can select the correct time range and drill down (also by showing DEBUG logs).

I feel like generally this is the case at the moment. However, upon sending the solution submission I see a lot of noisy alerts and am not really sure these are needed to be show on every run by default (see screenshot)

image

I therefore propose to downgrade the verbosity of these logs to debug. cc @sunce86 if those logs are still needed (I generally don't mind verbose logs to make debugging easier, but we should make sure they don't make other maintenance harder).

@fleupold fleupold requested a review from a team as a code owner May 5, 2022 12:19
@codecov-commenter
Copy link

Codecov Report

Merging #192 (5a7782d) into main (622607b) will increase coverage by 0.27%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
+ Coverage   64.59%   64.86%   +0.27%     
==========================================
  Files         186      190       +4     
  Lines       38629    38966     +337     
==========================================
+ Hits        24953    25276     +323     
- Misses      13676    13690      +14     

@fleupold fleupold enabled auto-merge (squash) May 6, 2022 08:56
@fleupold fleupold merged commit b028a87 into main May 6, 2022
@fleupold fleupold deleted the submit_log_verbosity branch May 6, 2022 08:59
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants