Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide module for Vec<u8> to hex string serialization #186

Merged
merged 2 commits into from
May 3, 2022
Merged

Conversation

vkgnosis
Copy link
Contributor

@vkgnosis vkgnosis commented May 2, 2022

We use web3::Bytes in a couple of places solely because it serializes to 0x prefixed hex string which we want in some apis. This behavior is not documented so we shouldn't rely on it. This PR introduces a custom serialization module with the same functionality.

Test Plan

CI, unit tests

@vkgnosis vkgnosis requested a review from a team as a code owner May 2, 2022 13:23
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2022

Codecov Report

Merging #186 (b26bae8) into main (d0eed4b) will increase coverage by 0.00%.
The diff coverage is 83.33%.

❗ Current head b26bae8 differs from pull request most recent head d9ff6d6. Consider uploading reports for the commit d9ff6d6 to get more accurate results

@@           Coverage Diff           @@
##             main     #186   +/-   ##
=======================================
  Coverage   64.58%   64.59%           
=======================================
  Files         185      186    +1     
  Lines       38602    38629   +27     
=======================================
+ Hits        24932    24952   +20     
- Misses      13670    13677    +7     

@vkgnosis vkgnosis enabled auto-merge (squash) May 3, 2022 09:15
@vkgnosis vkgnosis merged commit 622607b into main May 3, 2022
@vkgnosis vkgnosis deleted the hex-bytes branch May 3, 2022 09:19
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants