Shorten maintenance span #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking at Kibana I realized the hash adds too much visual noise for little benefit when it is prepended to every log message so I'm changing this to just say block=1234 and adding back the previous log message showing the hash.
Codecov Report
@@ Coverage Diff @@
## main #181 +/- ##
==========================================
+ Coverage 64.62% 64.82% +0.19%
==========================================
Files 185 185
Lines 38567 38400 -167
==========================================
- Hits 24924 24892 -32
+ Misses 13643 13508 -135 |
MartinquaXD
approved these changes
Apr 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at Kibana I realized the hash adds too much visual noise for
little benefit when it is prepended to every log message so I'm changing
this to just say block=1234 and adding back the previous log message
showing the hash.
Test Plan
observe changed output