-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLA Verification Worflow #169
Conversation
recheck |
Codecov Report
@@ Coverage Diff @@
## main #169 +/- ##
==========================================
+ Coverage 64.80% 64.83% +0.02%
==========================================
Files 185 185
Lines 38398 38388 -10
==========================================
+ Hits 24884 24889 +5
+ Misses 13514 13499 -15 |
Thanks Nick. Pr looks good. Just FYI: I thought I would have merged the external contribution from here: #162 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for setting this up!
LGTM.
I'm a little confused about the purpose of recheck
if the bot also gets triggered when someone comments the magic words.
When would somebody use recheck
?
Good question. This is mostly an artifact from copying the setup from https://github.com/contributor-assistant/github-action, but one case where it would be useful is if you have someone make a PR, then added to the team (making them exempt from CLA signing), then |
This PR adds a workflow for verifying CLA signatures for external contributors.
I detailed the steps for integrating here for other projects to use.
Basically, this workflow will first:
*[bot]
to the list of "allowed" GitHub users that don't need to sign the CLA.contributor-assistant/github-action
action to verify the CLA is signed. I used this action as it seemed to be, by far, the most popular one in the market place and keeps the signature file in-tree.Test Plan
Checkout the CLA file that was created.It turns out that thepull_request_target
triggers, the GitHub action needs to be inmain
, so the bot will be enabled after this is already merged. I tested it in a repo before creating this PR here: https://github.com/cowprotocol/cla-test.Also, if someone has a non-member account after this is merged (maybe @e00E), can they create a PR and check that the CLA bot flags it as CLA needed?